There is no reason for a subscriber to not connect to multiple publishers, so let's #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eile
force-pushed
the
master
branch
2 times, most recently
from
496ad9a to
392c106
Compare
tribal-tec
approved these changes
Jul 26, 2017
rdumusc
approved these changes
Jul 26, 2017
| std::string("Non-fully qualified URI used for subscriber"))); | ||
| } | ||
| if (uri.getScheme() == DEFAULT_SCHEMA && | ||
| (uri.getHost().empty() || uri.getPort() == 0)) |
There was a problem hiding this comment.
this could read more smoothly with a helper function:
if (!isFullyQualified(uri))
{ throw }
Or replacing the whole block:
checkFullyQualified(uri);
There was a problem hiding this comment.
Good point - I'll do it in #219 to avoid merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.