Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.targets file name must match NuGet package id #142

Merged
merged 1 commit into from
Jun 6, 2018
Merged

.targets file name must match NuGet package id #142

merged 1 commit into from
Jun 6, 2018

Conversation

dynamatt
Copy link

According to https://blog.nuget.org/20141023/package-manifests.html:

NuGet looks in the \build folder for props and targets files where the filename matches the package id.

This means that the targets will not be properly loaded unless the .targets file has the same name as the package ID. I believe this may fix issues #129 and #130.

Hence the "hdf5.targets" file should be renamed to "HDF.PInvoke.targets.

Copy link
Collaborator

@JanWosnitza JanWosnitza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fine. Is this due to changes in NuGet?

@gheber gheber merged commit 90b1c76 into HDFGroup:master Jun 6, 2018
@dynamatt
Copy link
Author

dynamatt commented Jun 6, 2018

Yes, I think so, but I’m not really an expert on how things used to be done - I just found this document.
It’s also related to the new format of importing into .csproj files. When you use this format the packages are cached into your %userprofile%/.nuget/packages folder rather than a packages folder in the solution directory. I think this is why we need to use .targets instead of a post-build action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants