Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable julia tests in develop. #5254

Closed
wants to merge 3 commits into from
Closed

Enable julia tests in develop. #5254

wants to merge 3 commits into from

Conversation

lrknox
Copy link
Collaborator

@lrknox lrknox commented Jan 21, 2025

No description provided.

byrnHDF
byrnHDF previously approved these changes Jan 21, 2025
View reviewed changes
@mattjala
Copy link
Contributor

I don't think these should be re-enabled until we expect them to pass. From the logs: 1348 passed, 5 failed, 1 errored, 2 broken.

What was the original reason these were disabled?

@jhendersonHDF
Copy link
Collaborator

I don't think these should be re-enabled until we expect them to pass. From the logs: 1348 passed, 5 failed, 1 errored, 2 broken.

What was the original reason these were disabled?

This PR was mostly to check the current status of the Julia tests in develop and see if they can be re-enabled. The original issue that they were disabled for (JuliaIO/HDF5.jl#1170) has since been fixed in develop, but it looks like these are new issues we haven't seen before and will need to be fixed.

@mattjala mattjala added Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - Testing Code in test or testpar directories, GitHub workflows Type - Task Actions that don't fit into any other type category labels Jan 23, 2025
@lrknox lrknox marked this pull request as draft January 23, 2025 15:47
@lrknox lrknox closed this Jan 23, 2025
@lrknox lrknox deleted the develop_enable_julia_tests branch January 23, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF left review comments

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Task Actions that don't fit into any other type category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lrknox @mattjala @jhendersonHDF @byrnHDF