Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for extended mermaid syntax #215

Closed
wants to merge 4 commits into from
Closed

feat: add support for extended mermaid syntax #215

wants to merge 4 commits into from

Conversation

HEIGE-PCloud
Copy link
Owner

@HEIGE-PCloud HEIGE-PCloud commented Sep 10, 2021 •
edited
Loading

  • Add a mermaid.enable option to manually enable mermaid when only using the ```mermaid syntax
  • Resolve the conflict with the original code block style
  • Update documentation

@HEIGE-PCloud HEIGE-PCloud added the enhancement Enhance existing features label Sep 10, 2021
@HEIGE-PCloud HEIGE-PCloud added this to the v0.2.13 milestone Sep 10, 2021
@HEIGE-PCloud HEIGE-PCloud self-assigned this Sep 10, 2021
@vercel
Copy link

vercel bot commented Sep 10, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pcloud/do-it/Ee6EnwSDjvFzLHhwBKzgkKku4G4s
✅ Preview: https://do-it-git-feat-mermaidjs-extended-syntax-pcloud.vercel.app

@HEIGE-PCloud HEIGE-PCloud linked an issue Sep 10, 2021 that may be closed by this pull request
[FEATURE] mermaid #207
Closed
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 10, 2021 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4aa0312
Status: ✅  Deploy successful!
Preview URL: https://0d1aff97.hugodoit.pages.dev

View logs

@HEIGE-PCloud
Copy link
Owner Author

HEIGE-PCloud commented Sep 10, 2021 •
edited
Loading

@thinkhp 我重写了原来了 mermaid shortcode，现在它不会引起冲突，可以同时支持两种语法。

在这个页面查看预览 https://do-it-git-feat-mermaidjs-extended-syntax-pcloud.vercel.app/mermaid-tests/

@HEIGE-PCloud
Copy link
Owner Author

It requires so many dirty work arounds to get it to work, so I am not planning to support it.

@HEIGE-PCloud HEIGE-PCloud marked this pull request as draft September 10, 2021 19:04
@HEIGE-PCloud
Copy link
Owner Author

HEIGE-PCloud commented Sep 10, 2021 •
edited
Loading

The correct way to go is to submit a PR to Hugo and makes it support the code block hook. Closing this.

@HEIGE-PCloud HEIGE-PCloud reopened this Oct 28, 2021
@HEIGE-PCloud HEIGE-PCloud changed the title Feature: Add support for extended mermaid syntax feat: add support for extended mermaid syntax Oct 29, 2021
@HEIGE-PCloud HEIGE-PCloud removed this from the v0.2.13 milestone Nov 7, 2021
@HEIGE-PCloud HEIGE-PCloud deleted the feat/mermaidjs-extended-syntax branch March 1, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HEIGE-PCloud HEIGE-PCloud

Labels
enhancement Enhance existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] mermaid
1 participant
@HEIGE-PCloud