Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use aws_ecs_cluster_capacity_provider resource #14

Merged
merged 2 commits into from
May 18, 2022
Merged

Use aws_ecs_cluster_capacity_provider resource #14

merged 2 commits into from
May 18, 2022

Conversation

sharu1204
Copy link
Contributor

Closes #13

@sharu1204 sharu1204 added the enhancement New feature or request label May 17, 2022
@sharu1204 sharu1204 requested review from michaelaw320 and hanscg May 17, 2022 01:53
@sharu1204 sharu1204 self-assigned this May 17, 2022
@michaelaw320
Copy link
Collaborator

Can you merge the latest main that fixes github actions? Thanks

michaelaw320
michaelaw320 approved these changes May 17, 2022
View reviewed changes
Copy link
Collaborator

@michaelaw320 michaelaw320 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's fix the failing CI on examples on separate PR

(Can you run the terrafom-docs specified in pre-commit to update the docs?)

@sharu1204
Copy link
Contributor Author

Can you run the terrafom-docs specified in pre-commit to update the docs?

@michaelaw320
I ran terraform-docs command

@michaelaw320 michaelaw320 merged commit 35da631 into HENNGE:main May 18, 2022
@sharu1204 sharu1204 deleted the capacityprovider branch May 18, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelaw320 michaelaw320 michaelaw320 approved these changes

@hanscg hanscg Awaiting requested review from hanscg

Assignees

@sharu1204 sharu1204

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

capacity_providers and default_capacity_provider_strategy arguments on aws_ecs_cluster have been deprecated
2 participants
@sharu1204 @michaelaw320