Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placement constraints #28

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Placement constraints #28

merged 4 commits into from
Jan 15, 2024

Conversation

michaelaw320
Copy link
Collaborator

@michaelaw320 michaelaw320 commented Jan 12, 2024 •
edited
Loading

Rework on placement constraints:

  • Split service and task def placement constraints
  • Add convenience flag on easy ec2 service to run the tasks on distinct instances

Will release 4.0.0 after this.
bumping major version because core module API kind of changed and old style cannot be used

FurqanHabibi
FurqanHabibi approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@FurqanHabibi FurqanHabibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelaw320 michaelaw320 merged commit 2138718 into main Jan 15, 2024
24 checks passed
@michaelaw320 michaelaw320 deleted the placement-constraints branch January 15, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanscg hanscg hanscg approved these changes

@FurqanHabibi FurqanHabibi FurqanHabibi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelaw320 @FurqanHabibi @hanscg