Avoid 'new line' symbols in string edges (YODA writer) #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I came across a recent submission from CMS that encodes the string edges for the independent axis in Table 2 like so:
which is an edge that involves two new line characters. These are not preserved by the browser-based view of the associated entry: it prints the edge in one line, which was presumably the intention anyway, but that is not necessarily the case for all output formats. I noticed them being propagated through by the YODA writer, which later on causes the reader to crash (which is a separate issue that I will deal with on the YODA side).
For the sake of this entry (and possibly others), I would propose to remove new-line characters entirely from string-based bin edges when assembling the YODA objects, as done in this change set.