Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily restore old array shape compatibility in HERAData for the sake of pspec #864

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

steven-murray
Copy link
Contributor

@steven-murray steven-murray commented Jan 19, 2023

This fixes compatibility with hera_pspec, which does not yet have future array shape support. I opened HERA-Team/hera_pspec#373 to make this happen, so we can revert to future array shapes after that.

@adeliegorce
Copy link
Contributor

adeliegorce commented Jan 19, 2023

Hi, I don't think I can review because I don't know hera_cal but just for info: I do think it is a numpy version problem because now calling np.float throws an error when before is was only a DeprecationWarning

adeliegorce
adeliegorce previously approved these changes Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 97.08% // Head: 97.07% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (eff4762) compared to base (541d065).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
- Coverage   97.08%   97.07%   -0.02%     
==========================================
  Files          19       19              
  Lines        8648     8652       +4     
==========================================
+ Hits         8396     8399       +3     
- Misses        252      253       +1     
Impacted Files Coverage Δ
hera_cal/io.py 98.41% <83.33%> (-0.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adeliegorce adeliegorce self-requested a review January 19, 2023 23:32
@steven-murray steven-murray changed the title fix: apparently can't inplace multiply while braodcasting Temporarily restore old array shape compatibility in HERAData for the sake of pspec Jan 19, 2023
@steven-murray steven-murray dismissed adeliegorce’s stale review January 19, 2023 23:53

turns out it was a different problem

Copy link
Member

@jsdillon jsdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. @steven-murray can you make an issue (and assign yourself) to undo this PR when hera_pspec is ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants