Apply suggestions from code review

Co-authored-by: Kevin Welsh <[email protected]>

setup.py

@@ -114,10 +114,6 @@ def get_pybind11_include_path():
 
 def get_cpp_extensions():
     cpp_transform_pkgdir = Path('hexrd') / 'transforms/cpp_sublibrary'
-    src_files = [
-        str(cpp_transform_pkgdir / 'src/transforms.cpp'),
-        str(cpp_transform_pkgdir / 'src/inverse_distortion.cpp'),
-    ]
 
     extra_compile_args = [
         '-O3',
@@ -139,15 +135,15 @@ def get_cpp_extensions():
 
     transforms_ext = Extension(
         name='hexrd.extensions.transforms',
-        sources=[src_files[0]],
+        sources=[cpp_transform_pkgdir / 'src/transforms.cpp'],
         extra_compile_args=extra_compile_args,
         include_dirs=include_dirs,
         language='c++',
     )
 
     inverse_distortion_ext = Extension(
         name='hexrd.extensions.inverse_distortion',
-        sources=[src_files[1]],
+        sources=[cpp_transform_pkgdir / 'src/inverse_distortion.cpp'],
         extra_compile_args=extra_compile_args,
         include_dirs=include_dirs,
         language='c++',

tests/transforms/test_make_binary_rmat.py

@@ -18,7 +18,8 @@ def test_make_binary_rmat():
 
         # Two binary rmats should be the identity
         assert np.allclose(rmat @ rmat, np.eye(3))
-
+        assert np.allclose(rmat.T @ rmat, np.eye(3)), "It is orthogonal"
+        assert np.all((np.abs(rmat) - 1 < 1e-10) | (np.abs(rmat) < 1e-10)), "It is binary"
         rmat_expected = rotMatOfQuat(
             quatOfAngleAxis(np.pi, np.c_[axis])
         )