Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-3535] Coverage >= 90% src/services/dashboards/resource.js #2519

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

nvms
Copy link
Collaborator

@nvms nvms commented Dec 5, 2024

Description of change

How to test

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@@ -305,7 +305,7 @@ const switchToTopicCentric = (input) => {
}
return [...reports, report];
}, output[topic].reports);
output[topic].resources = (resourceObjects || []).reduce((resources, resource) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch can be removed. We only end up at this evaluation because resourceObjects exists and is an array that we are currently iterating over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant