Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TTAHUB-3770] Breakout backup retention processing #2586

Merged
merged 6 commits into from
Jan 13, 2025
Merged

[TTAHUB-3770] Breakout backup retention processing #2586

merged 6 commits into from
Jan 13, 2025
+732 −129

Conversation

GarrettEHill
Copy link
Collaborator

@GarrettEHill GarrettEHill commented Jan 8, 2025 •
edited
Loading

Description of change

  • Relocate backup retention handling to its own step.
  • Limit to only deleting a max of 15 file sets per execution
  • Add a feature to the lock system to allow a build from the same branch to usurp the lock when the same job and a higher build id is used. This is to prevent canceled builds from leaving a lock in place and failing subsequent builds due to failing to acquire a lock

How to test

  • Trigger pipeline using either manual-retention-production or manual-retention-processed set to true.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete
  • QA review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@GarrettEHill GarrettEHill marked this pull request as ready for review January 10, 2025 06:56
@GarrettEHill GarrettEHill merged commit 7a3302b into main Jan 13, 2025
12 checks passed
@GarrettEHill GarrettEHill deleted the TTAHUB-3770/breakout-backup-retention-processing branch January 13, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewatermethod thewatermethod thewatermethod approved these changes

@nvms nvms Awaiting requested review from nvms

@hardwarehuman hardwarehuman Awaiting requested review from hardwarehuman

@kryswisnaskas kryswisnaskas Awaiting requested review from kryswisnaskas

@AdamAdHocTeam AdamAdHocTeam Awaiting requested review from AdamAdHocTeam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GarrettEHill @thewatermethod