Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify file statuses #325

Merged
merged 4 commits into from
Feb 25, 2021
Merged

Simplify file statuses #325

merged 4 commits into from
Feb 25, 2021

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Feb 25, 2021

Description of change
Simplified file statuses presented to user. The mapping is now

UPLOADING -> Uploading
UPLOADED -> Uploaded
UPLOAD_FAILED, QUEUING_FAILED -> Upload Failed
SCANNING_QUEUED, SCANNING -> Scanning
APPROVED -> Approved
REJECTED -> Rejected.

Once #317 is complete, then QUEUING_FAILED will be moved to Scanning since it will have retry for failed queuing.

How to test

  1. Pull down changes.
  2. Start the app
  3. While the clamav instance is still starting add a grantee, click save draft, and upload a file
  4. File status should display 'Uploaded'
  5. Refresh the page, File status should display 'Scanning'
  6. Wait for ClamAV to finish starting and for a success message from the worker.
  7. Refresh the page and status should now say 'Approved'
  8. Stop the redis instance (docker stop head-start-ttadp_redis_1)
  9. Upload a new file
  10. Status should be uploaded. It will stay uploaded until the request to que times out (approx 2 mins)
  11. Go make a cup of coffee or tea
  12. Come back and refresh the page. If status is still 'Updated ' then the request hasn't timed out yet
  13. Refresh the page, status should now be 'Upload Failed'
    Note: if you start redis again within the timeout period then queuing will succeed and the job will get processed, so we currently have some resiliency there for dropouts.
    Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

@dcmcand dcmcand requested a review from rahearn February 25, 2021 17:08
Copy link
Contributor

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rahearn rahearn merged commit ee38770 into HHS:main Feb 25, 2021
PatricePascual-ACF pushed a commit that referenced this pull request Jun 15, 2021
…m-Operations

Add links to TTAHUB System Operations wiki page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA: Document upload failed without notification
2 participants