Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration fix, Filter grantees to region and Small screen fixes #331

Merged
merged 33 commits into from
Mar 1, 2021

Conversation

jasalisbury
Copy link
Contributor

@jasalisbury jasalisbury commented Mar 1, 2021

307

Description of change
Duration field now supports half steps

How to test

  1. Pull down
  2. Create a new report, enter half an hour for duration (*.5) and click Continue. Note no error
  3. Enter a quarter of an hour for duration (*.25) and click Continue. Note you now see an error

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

154

Description of change
A user is only given a list of grantees/grants that they have permissions to.
Allowable permissions are defined as Admin, Read, Read+Write.

How to test
Pull changes and run
Go start a report and you should only see grants/grantee for section 14 (Assuming you are user 1 from seed data)

Previous Behaviour
When seeing the grant/grantee list you would see region 14 and region 9

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

318

Description of change

While working on #86, we noticed that the Activity Report Review page looked cramped on smaller screen sizes. This PR makes some adjustments to the layout on smaller screen widths so things are more readable.

  • Stack label/values for reviewItems, and adjust font size/weight on labels at small sizes
  • Adjust layout of Navigator, Navigator's SideNav for <1024 width screens

How to test

Open an Activity Report review page, scale the window to <1024px wide, and see how the layout changes

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

No Ticket

Description of change

There were a couple of typos in the schema that were causing Redoc to show errors. This fixes that.

How to test

Run the docker container for api-docs on main, then load http://localhost:5000/, see an error message. Then checkout this PR's branch and reload the URL, and docs should appear.

Issue(s)

  • None

Daniel Riquiac Gopar and others added 30 commits February 18, 2021 10:09
…adjustments

Adjust AR Review page layout on smaller screens
@jasalisbury jasalisbury requested a review from rahearn March 1, 2021 16:59
@jasalisbury
Copy link
Contributor Author

@dcloud @gopar Should this PR close the tickets assigned to you that are referenced in the description? (#184 & #318)

@gopar
Copy link
Contributor

gopar commented Mar 1, 2021

@dcloud @gopar Should this PR close the tickets assigned to you that are referenced in the description? (#184 & #318)

Yeah, should close out #154

Copy link
Contributor

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@rahearn rahearn merged commit 79eaf80 into HHS:main Mar 1, 2021
PatricePascual-ACF pushed a commit that referenced this pull request Jun 15, 2021
* Debug logger

* Move the run time from midnight to 4am
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: "Duration" field error Prefilter Grantee names and Grant IDs based on region
4 participants