-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duration fix, Filter grantees to region and Small screen fixes #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bels at small sizes
Fix broken paths in openapi schema
…adjustments Adjust AR Review page layout on smaller screens
…tess Allow to filter grants/grantees based on region
…hours Duration supports half hours
rahearn
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
PatricePascual-ACF
pushed a commit
that referenced
this pull request
Jun 15, 2021
* Debug logger * Move the run time from midnight to 4am
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
307
Description of change
Duration field now supports half steps
How to test
Continue
. Note no errorContinue
. Note you now see an errorIssue(s)
Checklist
154
Description of change
A user is only given a list of grantees/grants that they have permissions to.
Allowable permissions are defined as Admin, Read, Read+Write.
How to test
Pull changes and run
Go start a report and you should only see grants/grantee for section 14 (Assuming you are user 1 from seed data)
Previous Behaviour
When seeing the grant/grantee list you would see region 14 and region 9
Issue(s)
Checklist
318
Description of change
While working on #86, we noticed that the Activity Report Review page looked cramped on smaller screen sizes. This PR makes some adjustments to the layout on smaller screen widths so things are more readable.
How to test
Open an Activity Report review page, scale the window to <1024px wide, and see how the layout changes
Issue(s)
Checklist
No Ticket
Description of change
There were a couple of typos in the schema that were causing Redoc to show errors. This fixes that.
How to test
Run the docker container for api-docs on main, then load http://localhost:5000/, see an error message. Then checkout this PR's branch and reload the URL, and docs should appear.
Issue(s)