Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan and delete uploaded files, nodejs upgrade. #335

Merged
merged 90 commits into from
Mar 2, 2021
Merged

Scan and delete uploaded files, nodejs upgrade. #335

merged 90 commits into from
Mar 2, 2021

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Mar 2, 2021

280

Description of change
Adds support to delete files.

How to test

  1. Pull down changes.
  2. Upload files.
  3. Verify they are present in minio and the db.
  4. click on the trash can icon next to the file
  5. verify they are gone from minio and the db

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

333

Description of change
Change CLAMAV_ENDPOINT env var in all 4 environments.
Add TLS support for cloud.gov instances.

How to test
Go to https://tta-smarthub-sandbox.app.cloud.gov/ and start a new report.

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

324

Description of change

  1. Update to NodeJS 14.15.4, the latest LTS supported by nodejs_buildpack 1.7.41
  2. Upgrade all yarn dependencies to their most recent versions, except sequelize (on the latest 5.x series) and jest (react-scripts complains if we don't use that exact version)
  3. Break up docker compose files a bit to support easily running only db & services with docker and app code directly on the host machine.

How to test

  1. yarn deps:local/yarn docker:deps
  2. bin/run-tests --local/bin/run-tests

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

dcmcand added 30 commits February 22, 2021 16:17
@dcmcand
add file type filtering on the frontend
6021653
@dcmcand
Merge branch 'main' into cm-280-delete-files
7cfbfb3
@dcmcand
refactor to to add services/file.js
d9e5f34
@dcmcand
Add delete file route
b7c08f4
@dcmcand
add frontend changes
49e2860
@dcmcand
fix fileUrl in fetchers/file.js
7ebf561
@dcmcand
add backend tests
69e29bb
@dcmcand
update frontend tests
c374077
@dcmcand
add tests
31055b7
@dcmcand
Merge branch 'main' into cm-280-delete-files
6bc1f35
@dcmcand
add api documentation
c2a9193
@dcmcand
add api documentation
f70ac16
@dcmcand
fmt
60c95a1
@dcmcand
Merge branch 'main' into cm-280-delete-files
77ef865
@dcmcand
Merge branch 'main' into cm-280-delete-files
ba075f7
@dcmcand
Merge branch 'main' into cm-280-delete-files
f04bd3a
@dcmcand
add confirmation modal for file deletion
ff14fda
@dcmcand
styling
63d3aa1
@dcmcand
Add delete confirmation modal
adaa1ad
@dcmcand
add tests for file delete modal
0798506
@dcmcand
fmt
af148bc
@dcmcand
Squashed commit of the following:
c165a41 
commit 68a69d1
Merge: f9408ad 7f4d157
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 11:39:32 2021 -0500

    Merge pull request #196 from adhocteam/cm-310-update-file-statuses

    simplify file upload statuses

commit 7f4d157
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:43:33 2021 -0500

    fmt

commit b7724ce
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:39:19 2021 -0500

    add tests for getStatus()

commit cc12546
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:04:59 2021 -0500

    simplify file upload statuses
@dcmcand
fmt
41de3bc
@dcmcand
Squashed commit of the following:
71834d6 
commit 68a69d1
Merge: f9408ad 7f4d157
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 11:39:32 2021 -0500

    Merge pull request #196 from adhocteam/cm-310-update-file-statuses

    simplify file upload statuses

commit 7f4d157
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:43:33 2021 -0500

    fmt

commit b7724ce
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:39:19 2021 -0500

    add tests for getStatus()

commit cc12546
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:04:59 2021 -0500

    simplify file upload statuses
@dcmcand
fix merge issue
fb99b34
@dcmcand
update return status for delete api to 204
be55ad7
@dcmcand
Squashed commit of the following:
2835cf6 
commit 68a69d1
Merge: f9408ad 7f4d157
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 11:39:32 2021 -0500

    Merge pull request #196 from adhocteam/cm-310-update-file-statuses

    simplify file upload statuses

commit 7f4d157
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:43:33 2021 -0500

    fmt

commit b7724ce
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:39:19 2021 -0500

    add tests for getStatus()

commit cc12546
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:04:59 2021 -0500

    simplify file upload statuses
@dcmcand
Squashed commit of the following:
ef2168b 
commit 68a69d1
Merge: f9408ad 7f4d157
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 11:39:32 2021 -0500

    Merge pull request #196 from adhocteam/cm-310-update-file-statuses

    simplify file upload statuses

commit 7f4d157
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:43:33 2021 -0500

    fmt

commit b7724ce
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:39:19 2021 -0500

    add tests for getStatus()

commit cc12546
Author: Chuck McAndrew <[email protected]>
Date:   Thu Feb 25 10:04:59 2021 -0500

    simplify file upload statuses
@dcmcand
Merge branch 'main' into cm-280-delete-files
c9d20aa
@dcmcand
add file type filtering on the frontend
a0b7532
rahearn and others added 27 commits February 26, 2021 12:07
@rahearn
Deploy to sandbox
6396913
@dcmcand
refactor for testability and add tests
4cad3be
@dcmcand
refactor and fix tests
e0c7c96
@dcmcand
fmt
10d507f
@dcmcand
Merge branch 'main' into cm-280-delete-files
53794b4
@dcmcand
fix delete file bug
4a02a2b
@dcmcand
Merge branch 'main' into cm-280-delete-files
001324e
@dcmcand
Merge branch 'main' into cm-280-delete-files
2e8b277
@dcmcand
fmt
1ba1f3a
@dcmcand
add tls options for cloud.gov to redis
dc6acd5
@dcmcand
allow empty object for tls config
91b25a1
@dcmcand
fix generateRedisConfig
7d353e5
@dcmcand
change clamav endpoint
1ee704a
@dcmcand
add focus to deleteFile modal
0ef1fa4
@dcmcand
add focus to delete file modal
39c4cce
@dcmcand
Merge branch 'main' into cm-280-delete-files
b7a09da
@rahearn
Clean up postgres port assignments
ee254b6 
* add a README warning about the dev containers
* use a random port for bin/run-tests
* dont bind at all for the prod-style-server
@rahearn
Merge branch 'adhoc-main' into nodejs-update
2b6f903 
* adhoc-main: (29 commits)
  Default value and navigation updates
  Reports can be saved in draft mode even without recipients
  "new" id is replaced silently instead of triggering a reload
  Switch to deep compare useEffect
  Make Region non-required
  Remove unused file
  Updates from review
  Switch from email link to Smartsheet link for 'request permission' from Welcome screen
  Lint fix
  Add review from feedback
  Add missing tests
  Give that login placard the role=dialog. Set attributes for label and description
  Update Mock in test
  Updat test
  Update tests that rely on login placard
  Implement welcome placard, per design
  Duration supports half hours
  Prevent review page alerts from printing
  Form navigation more consistent
  lint fixes
  ...
@rahearn
Lint fixes
94f3cfb
@rahearn
Fix frontend tests
75fd9cb
@dcmcand
Merge branch 'main' into cm-fix-tls-for-redis
7f47a2b
@dcmcand
Merge pull request #203 from adhocteam/cm-fix-tls-for-redis
092f32a 
Cm fix tls for redis
@rahearn
Merge branch 'main' into cm-280-delete-files
05f697f
@dcmcand
Merge pull request #191 from adhocteam/cm-280-delete-files
0a54784 
Cm 280 delete files
@rahearn
Merge branch 'adhoc-main' into nodejs-update
d5823eb 
* adhoc-main: (63 commits)
  add focus to delete file modal
  add focus to deleteFile modal
  change clamav endpoint
  fix generateRedisConfig
  allow empty object for tls config
  add tls options for cloud.gov to redis
  fmt
  fix delete file bug
  fmt
  refactor and fix tests
  refactor for testability and add tests
  fix 2 tests
  fmt
  fix tests
  fmt
  update frontend and api docs to deal with authorization
  clean up after merge
  Clean up after merge
  Squashed commit of the following:
  Squashed commit of the following:
  ...
@rahearn
Update tests
5a564d1
@rahearn
Merge pull request #201 from adhocteam/nodejs-update
d0f5a95 
Nodejs & yarn updates
@rahearn rahearn merged commit ae93f65 into HHS:main Mar 2, 2021
@rahearn rahearn mentioned this pull request Mar 2, 2021
Closed
kryswisnaskas added a commit that referenced this pull request Jun 24, 2021
@kryswisnaskas
Fix region order and add non-grantees. (#335)
2f527a1 
* Add non-grantees; layout changes

* Deploy to sandbox

* Include legacy reports in statistics; limit to approved reports only

* Increase frontend test timeout

* Add a script to connect non-grantees to activity reports for legacy data

* Add a script to connect non-grantees to activity reports for legacy data

* Add a script to connect non-grantees to activity reports for legacy data

* Fix lint errors

* Fix test

* Remove non-legacy filter

* Remove statement

* Adjust test

* Remove new test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File scanning not happening in cloud.gov Delete uploaded files
2 participants
@rahearn @dcmcand