Ttahub 138 al tp survey on ar landing #481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First pass at a pattern for widgets * Set coverage limits to 0 so we deploy to staging These limits will be increased back to what they are on main before merging. * Reset coverage limits * TTA Overview widget initial commit * Add backend tests * Deploy to sandbox * Fix lint error * Fix frontend lint errors * Merge main and fix invalid region * Refactor test * Add frontend tests * Add frontend tests * Styling improvements * Add region number in caption * Update mocks in landing tests * Adjusted sizing, flickering * Add temp border to overview widget Co-authored-by: Josh Salisbury <[email protected]>
thewatermethod
added a commit
that referenced
this pull request
Nov 12, 2021
* first version of filter pills * added first version of filter pills * added tests for filter pill ui * change colors and add test * fixed issues found by Matt * fixed filter issues and specialists check boxes * fixed pill row spacing and moved AND to front * fix audit vuln * fix lint errors * wip * css fixes * code clean up * added unit test for tool tip and fixed filter pill test * align text in ellipsis pill * fixes based on Joshs PR review Co-authored-by: Matt Bevilacqua <[email protected]>
6 tasks
thewatermethod
added a commit
that referenced
this pull request
Nov 15, 2021
* fix prop type * db.sequelize.close returns a promise * fix unit test * building backend route for grantee search * create query for search * clean up function * add unit test * add size limit to query * fix broken ui test * update ui test for new features * add another ui test * beefed up unit test * beefed up second unit test * refactor fetching of widget data * add granteeId to scopes * remove unused file * remove widgets example page * add unit test * fix broken test * back end for grants list widget * build out GranteeResults * fixed placement of statistics to match mockup * add grantee results table * write ui test * add additional ui tests * backend fixes for grants program types * backend unit tests * update yarn vuln * starting to fill test coverage gaps * more work on ui tests * return fetchers to prev state * ui test for grantee search * another ui test * testing linter * remove test * test * remove inline function * fix bug where sort wasn't firing * why not? * removed shot in the dark * test this lint * test this lint * on apply remove as a test * defeated, we add no an eslint ignore * updates wip * fix unit tests * linter fixes * changes for grantee to use scopes with fixes * finish UI tests * more grantee list updates * first version of grants list widget * updates * unit test for Grants List FE * fix front end tests * fix all backend tests * minor ui update * change ids to see if test passes * updates * fix ui * add feature flag * clean up feature flag component and some naming * clean up fetcher * clean up css * rename determineFiltersToScopes to filtersToScopes * cleanup feature flag usage * filtering via model type * leverage existing filter code * more tweaking of feature flag * add missing param * add default sorting to grantee service * update grantee service * write unit tests for new scopes * fix ui tests * fix lint error * fix backend unit tests * fix lint errors * feature flag grantee record * refactor search endpoint to use new scopes * fix issues with grantee record page * fix flaky frontend test and iron out bugs with merge * remove extraneous comment * working on proper error handling; * remove failing tests for now * add back in unit tests * simplify fetching data * improve backend coverage * no magic numbers * add new tab components; * new layout changes * sensible defaults * fix backend test * wrote "a lot" of tests * add to feature flag tests * switch url structure * remove unneeded error override prop * fix indentation * users can't set 'modelType' * hoist Filter to its own scope * rename granteebyScopes to granteeById * refactor granteeById to use program table * rename granteesByNameAndRegion * required false on included model * remove unneeded filter * refactor loading logic for grantee search form * remove unnecessary condition * refactor programs on frontend * fix some unit tests * fix unit tests * remove console logs * create basic filter component * rearranging componentry * putting it all together * add todo comment * flopped those bad boys * flopped menu item order * add configurable fields to overview widget * always show search results (simplify loading logic) * show side nav as active when in any part of grantee record flow * style changes * refactor tooltips, add them to the overview widget * fix back to search link * fix grantee results page * fix tooltip text wrap, screenreader on overview * fix UI tests for grantee record page * simplify filter management * clean up filters some more * further filter cleanup * allow year to date as a filter option; * add key to render, refactor components * role filter should show overlap * working out the kinks * fix filter state and match mockup * add keyboard handling and descriptive page titles * further styling * writing tests * start unit tests * trying to fix post merge mistakes * fixing some merge mistakes * add some UI test * add additional unit tests * fix botched backend test and add frontend test * some small accessibility improvements * add refactor plan * begin refactoring * refactor and seperate button select and date range select * start another refactor * refactor menu usage * refactor dropdowns to use one component * add test for grantee search * cleanup TTA History filter * convert filter menu to dropdown menu * ui fixes after refactoring * fix more ui bugs * fill in some test coverage * add filter menu item test * get rid of duplicate constant * add test for filter date range * more test coverage * fix bug with filter blurring * fix blur interactions * fix weird checkbox behavior * bring date icons inline; * reset condition on topic change * remove debugging comment * ditch unused code so we don\'t have to test it * adapt test since query is killed by topic change * write test for button select * remove phantom state from checkbox select * refactor formatDateRange function * add test to date range select * remove unused code from filter menu that we shouldnt test * fix date range select label bug * fix specialist select blur bug * [TTAHUB-404] Add target populations to Grantee record page (#480) * add label to input in search form * create new widget front and back * ui test * put it in a grid * fix ui test * clean up tests * radd scopes to goals for grant * I put the where in the wrong place (oopsie) * fix test * Add SES to the diagram * Add to ignored yarn vulnerabilities Co-authored-by: unknown <[email protected]> * fix weird blur behavior * make grids agree * resolve merge issues * TTA-HUB: 397 Add Pill Filters to Grantee Page (#481) * first version of filter pills * added first version of filter pills * added tests for filter pill ui * change colors and add test * fixed issues found by Matt * fixed filter issues and specialists check boxes * fixed pill row spacing and moved AND to front * fix audit vuln * fix lint errors * wip * css fixes * code clean up * added unit test for tool tip and fixed filter pill test * align text in ellipsis pill * fixes based on Joshs PR review Co-authored-by: Matt Bevilacqua <[email protected]> * neaten the prop types * fighting against extra api calls * clear out query on condition * fix ui tests * add column header test * remove unneeded code * add another ui test * pass correct filters to the frequency graph * fix weird useState * refactor filter usage across TTA History * apply filters to table as well * add min width to menu * remove all specialists as an option * fix table colors * fix grantee record ui test * remove toggle all checked ui test * fix other failing tests * add test to column header * test * no div + caption * cleanup test * add test to mock * lwrite a test that works * we have to stop meeting like this Co-authored-by: Adam Levin <[email protected]> Co-authored-by: Adam Levin <[email protected]> Co-authored-by: Josh Salisbury <[email protected]> Co-authored-by: unknown <[email protected]>
kryswisnaskas
added a commit
that referenced
this pull request
Nov 29, 2021
* refactor and seperate button select and date range select * Bump validator from 13.6.0 to 13.7.0 Bumps [validator](https://github.com/validatorjs/validator.js) from 13.6.0 to 13.7.0. - [Release notes](https://github.com/validatorjs/validator.js/releases) - [Changelog](https://github.com/validatorjs/validator.js/blob/master/CHANGELOG.md) - [Commits](validatorjs/validator.js@13.6.0...13.7.0) --- updated-dependencies: - dependency-name: validator dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * start another refactor * refactor menu usage * refactor dropdowns to use one component * add test for grantee search * cleanup TTA History filter * convert filter menu to dropdown menu * ui fixes after refactoring * fix more ui bugs * fill in some test coverage * add filter menu item test * get rid of duplicate constant * add test for filter date range * more test coverage * fix bug with filter blurring * fix blur interactions * fix weird checkbox behavior * bring date icons inline; * reset condition on topic change * remove debugging comment * ditch unused code so we don\'t have to test it * adapt test since query is killed by topic change * write test for button select * remove phantom state from checkbox select * refactor formatDateRange function * add test to date range select * remove unused code from filter menu that we shouldnt test * final changes to export message from accessibility spec. * welcoming robots in certain situations * Update known vulnerabilities * trying a different approach in the config * fix date range select label bug * fix specialist select blur bug * [TTAHUB-404] Add target populations to Grantee record page (#480) * add label to input in search form * create new widget front and back * ui test * put it in a grid * fix ui test * clean up tests * radd scopes to goals for grant * I put the where in the wrong place (oopsie) * fix test * Add SES to the diagram * Add to ignored yarn vulnerabilities Co-authored-by: unknown <[email protected]> * is this how we set vars? * fix var name * fix ui tests * test on dev since sandbox does not do what I thought * update trusworks with modal changes * fix weird blur behavior * need to learn how to do bash * more bash better * tweak the export limit * for christmas sake * testing complete * fix ui test * fix bash script var names * make grids agree * resolve merge issues * TTA-HUB: 397 Add Pill Filters to Grantee Page (#481) * first version of filter pills * added first version of filter pills * added tests for filter pill ui * change colors and add test * fixed issues found by Matt * fixed filter issues and specialists check boxes * fixed pill row spacing and moved AND to front * fix audit vuln * fix lint errors * wip * css fixes * code clean up * added unit test for tool tip and fixed filter pill test * align text in ellipsis pill * fixes based on Joshs PR review Co-authored-by: Matt Bevilacqua <[email protected]> * neaten the prop types * updated file uploader modal * fighting against extra api calls * clear out query on condition * updated external resource modal * fix ui tests * move logic to circlci config * add column header test * remove unneeded code * add another ui test * awaken robot on prod * Update .circleci/config.yml Co-authored-by: Josh Salisbury <[email protected]> * adjust maxiumum number; * fix unit test again * add approvedat migration * update approvedAt on approval * clean up constants, add new one * add approved and created dates to fe landing page * add approved and created date to csv download * remove console statement * fixing tests * pass correct filters to the frequency graph * fix weird useState * refactor filter usage across TTA History * fixed modal unit tests * updated my alert test * fixed modal tests for external resource * partial fixes for ui tests * clean up prop type * cleanup UI tests * more unit test fixes for trussworks2 * idle modal test fixes * add backend tests * apply filters to table as well * add min width to menu * fixed accessibility issue and added test coverage * add target populations to ar * remove all specialists as an option * fix table colors * add approved and created date to ar, table css fixes * fix failing ui test * fix grantee record ui test * remove toggle all checked ui test * fix other failing tests * fix failing tooltip test * unique id value * update known issues * just checking, there is no way I fixed this * deploy feat. to dev * fix axe * Update known vulnerabilities * fix axe again * fix axe issues again * add test to column header * try heading axe fix * test * update test for axe * update * no div + caption * cleanup test * see if remvoing display none fixes issue * add test to mock * hide headings * limit number of headings * lwrite a test that works * temp remove unit test * style alert a little better * fix some ui interactions * added cusom accordion with heading size prop * added test for accordion * redo date picker logic * update date range select further * add explanatory comment * we! test! our! code! * fix capitalizations while we're here * fixes based on Kryss comments * linter fixes * audit vuln * change unlock report button css to outline * export maximum for use in test * upgrade test * added save animation and save alert on review submit * fix table colors * update date picker within activity report * debug statement * port start date functionality to ar createe * meet jira criteria for targetPopulationTable * remove test that is no longer needed * added unit tests for new changes * change CSV warning start date * move func to own line per Matts comment * grantee scope change * first round of changes wip * tests and changes for PS and GS on results and summary * refine search results * fix error message fade in * fix test * standardize table color override * fix issue with one PS being displayed showing trailing comma * audit vuln * audit vuln BE * increase prod memory limit * audit known issues update * update audit vulnerabilities output * update audit vulns * update frontend vulns * fix menu css * fix alert for screen reader * maximum export exported * revise test to be flexible * move filters * fix regional dashboard legend styles * fixes based on PR review * return grantee type on granteeById * remove console statement * added grantee type * audit vuln * smooth smaller screen styles * rmenu aria label is prop * pass correct label * simplify code so no need to test * wrote some test coverage * audit vlun again * fix test after merge * fix test post merge * changes for program types in grant list widget * remove deploy * remove commented out css * ensure program type list is always distinct and sorted * remove unused css * update node to lts * deploy to dev * update axe * update axe and selenium * trying to set chromedriver path another way * file path both ways * does this work? * fix syntax error * replace existing * dont set chromedriver path * update chromedriver to 96 * update chromedriver * lets set a chromedriver * try a different chrome flavor * lets see if this works * test v96 of chrome * install right version of chrome 96 * revert to chrome 93 * add stripes back to tables * Remove aria announcements on total tta graph and fix CSS select * fix failing unit test Co-authored-by: Matt Bevilacqua <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Levin <[email protected]> Co-authored-by: Adam Levin <[email protected]> Co-authored-by: Josh Salisbury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added survey button to AR Landing screen for TouchPoints survey.
How to test
Go to the AR Landing Screen and click the feedback button.
Issue(s)
Checklists
Every PR
Production Deploy
After merge/deploy