Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-174]/update list of topics plus admin diagnostics table #498

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Jul 9, 2021

174

Description of change

  • Update topic names in the front end javascript constants in which they live
  • Write a recurring job to execute a sequelize update function to rename the offending topics
  • Added unit test for job

How to test

Create a new activity report, go to the topics and resources pane

Confirm that the topics are in alphabetical order and that:

"CLASS: Classroom Organization"
"Behavioral/Mental Health / Trauma"
"Curriculum (Instructional or Parenting)"
"Environmental Health and Safety / EPRR"
"Quality Improvement Plan/QIP"

appear.

To test recurring job aside from unit test, you'll need to run the updateTopicNames function and have some of the un-renamed topics in the database. As an example, to run it locally for me, I added it to an API handler so it would run arbitrarily, and ran SQL statements to confirm that the topics had been renamed.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] API Documentation updated
  • [n/a] Boundary diagram updated
  • [n/a] Logical Data Model updated
  • [n/a] Architectural Decision Records written for major infrastructure decisions

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

96

Description of change

Since the production db access is limited, this PR exposes one of the tables used for debugging. With the change the request errors table is visible and records can be deleted. The frontend component - react-admin provides a lot of functionality by default.

How to test

  • go to https://tta-smarthub-dev.app.cloud.gov/
  • navigate to the admin UI
  • verify that there is a button with "diag" on it
  • click on the "diag" button
  • verify that a Requesterrors displays without data in it

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

thewatermethod and others added 2 commits July 9, 2021 10:38
* renamed topics in constants

* update topics names function and test written

* update topics names function and test written

* comment and add to scheduled job

* fix failing frontend test

* use logger.info instead of console.log

* adjust spacing in qip field

* fix failing backend test
* Request errors api

* Request errors api

* Added data provider

* Added show

* Add backend tests

* Address feedback from review, add frontend test

* Deploy to sandbox
@kryswisnaskas kryswisnaskas changed the title [TTAHUB-174]/update list of topics [TTAHUB-174]/update list of topics plus admin diagnostics table Jul 9, 2021
@thewatermethod thewatermethod merged commit 31090ed into HHS:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants