Specify nodejs buildpack version #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to specify nodejs buildpack version
PatricePascual-ACF
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Thanks, @jasalisbury. I didn't know how to test in Sandbox but I trust that's done and approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
A recent nodejs buildpack update (
1.7.54->1.7.56) is incompatible with the version of node used by the application. We use node14.16.1which is no longer supported by buildpack1.7.56. To prevent this from happening in the future and allow us to investigate the nodejs version update in a more controlled way we now try to explicitly set the buildpack version.How to test
Verify deploy to sandbox is successful
Checklists
Every PR
[ ] Meets issue criteria[ ] JIRA ticket status updated[ ] Code is meaningfully tested[ ] Meets accessibility standards (WCAG 2.1 Levels A, AA)[ ] API Documentation updated[ ] Boundary diagram updated[ ] Logical Data Model updated[ ] Architectural Decision Records written for major infrastructure decisionsProduction Deploy
After merge/deploy