Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme link #520

Closed
wants to merge 6 commits into from
Closed

Fix readme link #520

wants to merge 6 commits into from

Conversation

SarahJaine
Copy link
Contributor

Description of change

URL was incorrectly styled in the README.md, which broke the weblinks for an entire list

BEFORE

Screen Shot 2021-07-01 at 2 46 41 PM

AFTER

Screen Shot 2021-07-01 at 2 46 20 PM

How to test

Check rich text formatted version of readme

Issue(s)

Checklists

Every PR

  • [n/a] Meets issue criteria
  • [n/a] JIRA ticket status updated
  • Code is meaningfully tested
  • [n/a] Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] API Documentation updated
  • [n/a] Boundary diagram updated
  • [n/a] Logical Data Model updated
  • [n/a] Architectural Decision Records written for major infrastructure decisions

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

SarahJaine and others added 6 commits July 1, 2021 14:45
* upgrade react-scripts

* add browserslist, glob-parent, tar

Co-authored-by: Sarah-Jaine Szekeresh <[email protected]>
… language changes (#376)

* make sure we have a full line of numbers;

* remove comment

* prevent plotly from converting date strings to int

* change legend to "grants served"

* Removed Active Grant Count, centered legend items, and updated tests.

* More fixes and updates.

* Added num of participants to dashboard overview.

* Fix linting error.

* Added helper function for comma separator and hooked up to top dashboard widget

* Updated AR landing and reason list with comma sep.

* Fix audit vuln

* Add comma sep to total tta hrs graph and fixed unit test.

* Added comma sep to topic freq chart.

* Rollback from Analytics to Dashboard...

* Cleaned up dashboard to prevent additional async calls

* Fix linting error and test

* Fixes based on Joshs comments

* grab main fe yarn-audit-known-issues

* test deploy to sandbox

* switch num of participants to its own query

* Fix linting

Co-authored-by: Adam Levin <[email protected]>
Co-authored-by: Sarah-Jaine Szekeresh <[email protected]>
* first try at addTransaction mw

* comment

* move to mw folder

* lets not modularize early

* add HTTP verb

* add /

* add comment just to kick circleci

Co-authored-by: Sarah-Jaine Szekeresh <[email protected]>
@SarahJaine
Copy link
Contributor Author

SarahJaine commented Aug 5, 2021

Opened against wrong base AGAIN- I've got to slow down here 😆 This is the correct PR adhocteam#381

@SarahJaine SarahJaine closed this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants