-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topic/reasons graph widget #606
Conversation
* pull bar graph into it's own component * bar graph now scrolls just the graph content, allows title/labels to still be shown when the graph is scrolled * add topic/reason freq widget. Can switch between display of reasons or topics * added backend test helpers to quickly (as in how long to code) create activity reports and destroy them for tests, along with any needed associations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had several comments written when I realized I'll have to restart my computer in order to actually test it out. Looks great so far though!
I actually seem to be running into the same issue as previous, where using the Plot.ly react library crashes my docker container. I'll set aside some time to try and figure out if I can fix this on my setup I apologize, I should have documented having this issue at the time |
Strange. Let me know if you can't get it to work, I haven't seen anything like that locally. |
Move button outside of H2 tag. Graph is focusable (so scrollable with keyboard)
Not sure if this should be specific to this review, but are we doing any compaction or compression on the js files are all data from the server to reduce bandwidth/download size? Would incorporating something like https://hub.docker.com/r/tdewolff/minify be a good idea? |
Network tab from the prod site (without caching) From Looks like (Note this does NOT include the new plotly dependency) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to work on the accessibility!
Re: the bundle size issue - seems like 99% of our users would not experience much of a downside for having a giant bundle. (I would still think that low-bandwidth users might need a more engineered solution, but that's an issue for another day!)
Seems like we have a setting in github where a commit after a review resets the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Description of change
How to test
Browse to the grantee tta record page
Issue(s)
Checklists
Every PR
Production Deploy
After merge/deploy