Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-160] final changes to export message from accessibility spec. and lowering limit #612

Merged
merged 6 commits into from
Nov 15, 2021

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Nov 8, 2021

Description of change

Changes to the "over-the-limit" export menu

  • Out of accessibility review, we rethought having a disabled button at all, since the user experience for a disabled control like that can be quite poor. Instead of disabling the button, we remove it. In order to give additional context to the menu's functionality that the button was previously providing, we change the dropdown from "Reports" to "Export reports"
  • Removed ellipsis on those menu actions, also as per UI/accessibility review
  • Reports from users indicate that 5000 might be too high of a limit. We have lowered it to 4000.

How to test

Attempt to export more than 5000 reports. Confirm that the error message appears, and the button does not. Attempt to export less and confirm it works as normal.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] API Documentation updated
  • [n/a] Boundary diagram updated
  • [n/a] Logical Data Model updated
  • [n/a] Architectural Decision Records written for major infrastructure decisions

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod changed the title [TTAHUB-160] final changes to export message from accessibility spec. [TTAHUB-160] final changes to export message from accessibility spec. and lowering limit Nov 9, 2021
@thewatermethod thewatermethod marked this pull request as ready for review November 9, 2021 18:06
jasalisbury
jasalisbury previously approved these changes Nov 10, 2021
Copy link
Contributor

@jasalisbury jasalisbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would double check the max supported at standup/office hours and try to get it lower. I imagine we will still hit a lot of errors with the limit at 4k

@thewatermethod thewatermethod merged commit fb7878d into main Nov 15, 2021
@thewatermethod thewatermethod deleted the TTAHUB-160/final-export-warning-changes branch November 15, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants