welcoming robots in certain situations #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewatermethod
requested review from
kryswisnaskas,
jasalisbury,
AdamAdHocTeam and
GarrettEHill
jasalisbury
reviewed
Nov 9, 2021
bin/robot-factory
Outdated
| @@ -0,0 +1,10 @@ | |||
| #!/bin/bash | |||
|
|
|||
| if [[ "$CURRENT_GIT_URL" == "$PROD_GIT_URL" && "$PROD_GIT_BRANCH" == "$CURRENT_GIT_BRANCH" ]]; | |||
There was a problem hiding this comment.
Do we want to move this check out into the circle-ci config? I think I like it better there, but open to other opinions.
There was a problem hiding this comment.
Something like this? I'm agnostic.
Didn't work when I tried it, that's how I got sent down the environment variable route but I think I know why that was.
- when: # prod
condition:
and:
- equal: [<< pipeline.project.git_url >>, << pipeline.parameters.prod_git_url >>]
- equal: [<< pipeline.git.branch >>, << pipeline.parameters.prod_git_branch >>]
steps:
- build_robot: #build robotThere was a problem hiding this comment.
yeah something like that. If you can't get it to work I think it is fine to leave it in the script.
jasalisbury
previously approved these changes
Nov 10, 2021
Co-authored-by: Josh Salisbury <[email protected]>
jasalisbury
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Right now, the same robots.txt file is served across all environments, in which all indexing is allowed, leading to Google indexing non-prod environments. This PR makes the robots.txt file disallow all by default and adds a bash script that runs on deploy. If the deploy is for prod, then the robots.txt file will be altered to allow indexing.
How to test
I have tested this out by adding a comment to the robots.txt on dev.
Issue(s)
Checklists
Every PR
Production Deploy
After merge/deploy