Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-430] add approved and created date to activity report tables #616

Merged
merged 15 commits into from
Nov 12, 2021

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Nov 10, 2021

Description of change

  • Added approvedAt as a database column. This is set to the most recent timestamp when the report status changed to approved. Otherwise it is null. Unlocking a report doesn't erase this column, but re-approving it afterwards does overwrite it.
  • Added created date to the my alerts widget on the activity-reports page
  • Added created date and approved date to the activity reports widget
  • Added both fields to the CSV (the same function generates exports for both tables - if there isn't an approval date, it will be blank)

How to test

View the tables on /activity-reports and export CSVs. Check that the fields described above are displayed, and that everything else appears correct.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] API Documentation updated
  • [n/a] Boundary diagram updated
  • [n/a] Logical Data Model updated
  • [n/a] Architectural Decision Records written for major infrastructure decisions

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod changed the title Ttahub 430/add approved and created date to ar [TTAHUB-430] add approved and created date to activity report tables Nov 11, 2021
@thewatermethod thewatermethod marked this pull request as ready for review November 11, 2021 18:43
Copy link
Collaborator

@kryswisnaskas kryswisnaskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Verified that the approvedAt date is updated in the database when the report is approved by all approvers.

@thewatermethod thewatermethod merged commit f170803 into main Nov 12, 2021
@thewatermethod thewatermethod deleted the TTAHUB-430/add-approved-and-created-date-to-ar branch November 12, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants