[TTAHUB-451] Add target populations to approved report #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewatermethod
requested review from
AdamAdHocTeam,
GarrettEHill,
jasalisbury and
kryswisnaskas
| @@ -386,6 +388,7 @@ export default function ApprovedActivityReport({ match, user }) { | |||
| recipientType, | |||
| 'Reason', | |||
| 'Program Type', | |||
There was a problem hiding this comment.
I know this is not your change, but should "Type" have a capital 'T'?
There was a problem hiding this comment.
Yep. Lauren & Kelly are preparing a list of capitalization for us to fix now that we've decided on a style, but totally make sense to fix this while I'm here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The approved activity report now shows target populations.
How to test
View an approved (non-legacy) AR. (/activity-reports/view/{id})
Target populations is a field under Program Type in the activity summary.
Issue(s)
Checklists
Every PR
Production Deploy
After merge/deploy