Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for third-party security tools #100

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Conversation

alexsoble
Copy link
Contributor

What does this change?

Resolves #36.

What does this change look like?

Preview link. 👁️

@alexsoble alexsoble assigned amymok, carjug and ninamak and unassigned amymok, carjug and ninamak Jul 20, 2021
@alexsoble alexsoble requested review from amymok, carjug and ninamak July 20, 2021 21:08
Copy link
Contributor

@carjug carjug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@amymok amymok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one change request


#### GitHub CodeQL

* GitHub offers a static analysis tool called Dependabot, which other 18F teams are using successfully.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Dependabot" should be "CodeQL" here

@amymok amymok self-requested a review July 21, 2021 19:42
Copy link
Contributor

@amymok amymok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexsoble
Copy link
Contributor Author

@ninamak You're the last approver on this one — I believe that once this merges, we are all done with our initial round of Architecture Decision Records / tech choices! 🎉 🎉

Copy link
Contributor

@ninamak ninamak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ninamak ninamak merged commit 79a6193 into main Jul 21, 2021
@alexsoble alexsoble deleted the ars/36/adr-for-security-tools branch August 26, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide on security analysis tools
5 participants