Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds CAN Funding Received form #3246

Merged
merged 20 commits into from
Jan 13, 2025

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Dec 20, 2024

What changed

  • adds CAN Funding Received Form
  • adds validation
  • handles cancel actions
  • handles api calls for both forms
  • updates line graph logic
  • adds placeholder prop for CurrencyInput component allowing for placeholder values to be added

Issue

#310 #3100

How to test

  1. watch e2e tests pass or manually:
  2. login as budget team
  3. goto /cans/504/funding
  4. click on edit button
  5. enter 5,000,000 for CAN Budget
  6. click on Add FY Budget
  7. add 1,000,000 for Funding Received
  8. click on Add Funding Received Button
  9. Verify amount is shown in Funding Received YTD Card
  10. Verify that amount is added to the Funding Received YTD Table
  11. Click on Save changes
  12. Verify Funding Received additions are persisted

Screenshots

If relevant, e.g. for a front-end feature

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

@maiyerlee maiyerlee force-pushed the OPS-310/3100_CAN_funding_received_form branch from 24bc90f to ceba0cd Compare January 8, 2025 20:04
@@ -38,6 +38,7 @@ const CANBudgetForm = ({ budgetAmount, cn, res, fiscalYear, handleAddBudget, run
value={budgetAmount || ""}
messages={res.getErrors("budget-amount")}
className={cn("budget-amount")}
placeholder={`$${totalFunding}`}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ nice addition @weimiao67

@fpigeonjr fpigeonjr changed the title wip: adds CAN Funding Received form feat: adds CAN Funding Received form Jan 10, 2025
@weimiao67 weimiao67 marked this pull request as ready for review January 10, 2025 16:03
@weimiao67 weimiao67 self-requested a review January 10, 2025 16:04
@weimiao67 weimiao67 added the javascript Pull requests that update Javascript code label Jan 10, 2025
Copy link
Contributor

@Santi-3rd Santi-3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests passed 👍

@fpigeonjr fpigeonjr merged commit f94edac into main Jan 13, 2025
42 checks passed
@fpigeonjr fpigeonjr deleted the OPS-310/3100_CAN_funding_received_form branch January 13, 2025 16:20
Copy link

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants