-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds CAN Funding Received form #3246
Conversation
24bc90f
to
ceba0cd
Compare
@@ -38,6 +38,7 @@ const CANBudgetForm = ({ budgetAmount, cn, res, fiscalYear, handleAddBudget, run | |||
value={budgetAmount || ""} | |||
messages={res.getErrors("budget-amount")} | |||
className={cn("budget-amount")} | |||
placeholder={`$${totalFunding}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ nice addition @weimiao67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the tests passed 👍
🎉 This PR is included in version 1.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What changed
placeholder
prop for CurrencyInput component allowing for placeholder values to be addedIssue
#310 #3100
How to test
/cans/504/funding
Screenshots
If relevant, e.g. for a front-end feature
Definition of Done Checklist