Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CAN List filtering by Budget #3373

Merged
merged 12 commits into from
Jan 31, 2025
Merged

fix: CAN List filtering by Budget #3373

merged 12 commits into from
Jan 31, 2025

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Jan 27, 2025 •
edited
Loading

What changed

  • squashed CAN List filtering bug

Issue

#3271

How to test

  1. e2e tests pass or:
  2. goto /cans
  3. select 2023 for FY filter
  4. select 500_000 for max Budget filter
  5. should only see 1 item in table

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [ ] Form validations updated

@fpigeonjr fpigeonjr added the bug Something isn't working label Jan 27, 2025
@fpigeonjr
Copy link
Contributor Author

may be a duplicate of #3325

@fpigeonjr fpigeonjr marked this pull request as draft January 27, 2025 17:38
maiyerlee and others added 11 commits January 27, 2025 16:00
@maiyerlee
Merge branch 'OPS-3271/filter-bug' of https://github.com/HHS/OPRE-OPS …
fade31d 
…into OPS-3271/filter-bug
@maiyerlee
fix: update can summary endpt filter by budget fiscal year
1191048
@maiyerlee
feat: update schema to require funding field on /can-funding-reciev…
67ef2e3 
…ed (#3337)

* feat: make funding required on create and update CAN funding received

* test: rename test
@Santi-3rd @maiyerlee
fix: wip fiscal year fixes
731814e
@maiyerlee
fix: update can summary endpt filter by budget fiscal year
6d69c78
@maiyerlee
Merge branch 'OPS-3271/filter-bug' of https://github.com/HHS/OPRE-OPS …
e271c3f 
…into OPS-3271/filter-bug
@fpigeonjr
refactor: getSortedFYBudgets to use fiscal year
228ef86
@fpigeonjr
test: update test data role
f2c3604
@maiyerlee
test: partial fix to backend unit test
f885e19
@maiyerlee
test: fix backend unittest and add filtering e2e test
0c21bda
@maiyerlee
chore: merge from main and fix merge conflict
0f06951
@fpigeonjr fpigeonjr linked an issue Jan 29, 2025 that may be closed by this pull request
FY Budget filter for All CANs page not updating 1 CAN according to adjusted range #3271
Closed
@fpigeonjr fpigeonjr marked this pull request as ready for review January 29, 2025 22:26
@fpigeonjr fpigeonjr changed the title fix: wip fiscal year fixes fix: CAN List filtering by Budget Jan 29, 2025
@fpigeonjr fpigeonjr merged commit 70a56e3 into main Jan 31, 2025
42 checks passed
@fpigeonjr fpigeonjr deleted the OPS-3271/filter-bug branch January 31, 2025 00:10
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.36.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weimiao67 weimiao67 weimiao67 approved these changes

@Santi-3rd Santi-3rd Santi-3rd approved these changes

@maiyerlee maiyerlee maiyerlee approved these changes

@johndeange johndeange Awaiting requested review from johndeange

@rajohnson90 rajohnson90 Awaiting requested review from rajohnson90

@jonnalley jonnalley Awaiting requested review from jonnalley

@devops-chris devops-chris Awaiting requested review from devops-chris

Assignees

@maiyerlee maiyerlee

@Santi-3rd Santi-3rd

@weimiao67 weimiao67

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FY Budget filter for All CANs page not updating 1 CAN according to adjusted range
4 participants
@fpigeonjr @maiyerlee @Santi-3rd @weimiao67