-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds final state draw.io skeleton architecture diagram #65
Conversation
Question for the group: do we also need to add an ADR for the architecture we've come up with? That feels like it'd be covered by the tech stack ADR mostly, but....I wasn't quite sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I would suggest to rename the file to something like final_state_architecture_diagram.png
, architecture_diagram.png
, etc. because as-is reads like state_diagram
, and it may be confusing that this is an actual "state diagram" and not an architecture diagram.
I think we need to explain and record some of the choices as ADRs if we haven't yet. For example, CircleCI, S3. |
Got it! Fixed |
Looks good to me as a starting point! A good visual we can use to talk with our PM and PO! I approve this PR, but I think we'll also want PM and maybe PO review for this one. |
I can also easily import the PNG into draw.io and edit it, which is great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Oh I do not mean adding to this issue, I am just saying we should probably have an ADR on those. |
Would it work to walk me through this diagram during our Demo block on Mon (7/12)? Who is going to create cards for the ADRs that need to be written up? |
@ninamak Sure, I can walk you through it. |
What does this change?
Adds png for our desired final state architecture diagram to our documentation
What does this change look like?
GitHub cards
Completes part of #27