Bump version to 1.0.7 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tests verify the resource type label, rather than the URI, to accomodate a potential fix for 119. - Tests also verify more than the GeographicalDescriptor, but also other similar entities such as TopicalDescriptor, PublicationType, CheckTag, SCR_Chemical, SCR_Disease, and SCR_Chemical. - On the github issue, we discussed fixing this by matching the longest vocabulary URI, but that was not successful because meshv:SCR_Disease is going to be shorter than meshv:SupplementaryConceptRecord. The issue is still fixed in JavaScript by establishing a priority function for the resource types returned by the Explorer rest controller. - An alternative fix would affect Lodestar upstream, and modify the order of responses by the explorer servlet, but that might have unintended consequences.
- Test code developed for the bug is preserved - `lode.explorer.useInference` was changed from its default in our repository - However, none of our tests fail through turning it off - This is more as Simon Jupp originally intended
Bugfix/120
- Add test to make sure that /mesh/void and /mesh/void#MeSHRDF resolve - Change configuration for URL rewriting so that they do
The meta sub-directory already contains the vocabulary and void files, so change the configuration of the Maven WAR Plugin to pull these from that location and delete the copies I have had to maintain.
Address github issue #121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of push to QA