Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put the users email address in the token returned by our auth logic #3246

Closed
2 tasks
chouinar opened this issue Dec 17, 2024 · 0 comments · Fixed by #3276
Closed
2 tasks

Put the users email address in the token returned by our auth logic #3246

chouinar opened this issue Dec 17, 2024 · 0 comments · Fixed by #3276
Assignees
@mikehgrantsgov

Comments

@chouinar
Copy link
Collaborator

Summary

This is very similar to the work done in #3199

One difference is that email isn't stored in the user table, but instead in the LinkExternalUser object. A user can have multiple linked external user records, but for now we'll assume they have a single one (the Login.gov one) where the email is stored.

Acceptance criteria

  • Email added to token
  • Tests updated
@chouinar chouinar moved this from Icebox to Todo in Simpler.Grants.gov Product Backlog Dec 17, 2024
@doug-s-nava doug-s-nava mentioned this issue Dec 17, 2024
Closed
2 tasks
@mikehgrantsgov mikehgrantsgov self-assigned this Dec 17, 2024
@mikehgrantsgov mikehgrantsgov moved this from Todo to In Progress in Simpler.Grants.gov Product Backlog Dec 17, 2024
@mikehgrantsgov mikehgrantsgov mentioned this issue Dec 17, 2024
Merged
doug-s-nava pushed a commit that referenced this issue Dec 30, 2024
@mikehgrantsgov @doug-s-nava
[Issue #3246] Put the users email address in the token returned by ou…
9828127 
…r auth logic (#3276)

## Summary
Fixes #3246

### Time to review: 10 mins

## Changes proposed
Add email address to JWT token if exists.

## Context for reviewers
A user can have multiple linked external user records, but for now we'll
assume they have a single one (the Login.gov one) where the email is
stored.

## Additional information
See addition to unit test covering scenarios where emails exists and
does not exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikehgrantsgov mikehgrantsgov

Labels
None yet
Projects
Simpler.Grants.gov Product Backlog
Status: Done
Milestone
No milestone
2 participants
@chouinar @mikehgrantsgov