[Issue 1037] Allow choosing between multiple VPCs #1052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In service of, but does not resolve, #1037
Time to review: 5 mins
Changes proposed
Context for reviewers
The Nava template has been updated to use non-default VPCs as our core networking layer. Migrating to that infrastructure will take quite some time, so I'm doing it piece by piece. The center of this piece is this code:
Which maps
environment
tovpc name
. Currently, onlystaging
is using a non-default VPC. I plan on having a long running branch (here: #1044) where I thoroughly test the staging VPC before merging it. This PR allows me to merge code that uses the non-default VPC, exclusively in our staging configuration.Additional information
Here is the proposed network design that I am working towards:
Here is the temporary network design as of this PR