Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DMS] Update security groups via terraform #1069

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[DMS] Update security groups via terraform #1069

merged 1 commit into from
Jan 23, 2024

Conversation

aplybeah
Copy link
Contributor

@aplybeah aplybeah commented Jan 23, 2024 •
edited
Loading

Summary

Part of #1038

Time to review: x mins

Changes proposed

  • update the security group for the replication instance in us-east-1

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

@aplybeah aplybeah requested a review from coilysiren January 23, 2024 21:15
coilysiren
coilysiren approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@aplybeah aplybeah merged commit aadd75d into main Jan 23, 2024
7 checks passed
@aplybeah aplybeah deleted the vpc-testing branch January 23, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coilysiren coilysiren coilysiren approved these changes

Assignees
No one assigned
Labels
terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aplybeah @coilysiren