[Issue 1051] Deploy dev to non-default dev VPC #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
changed the title
jamesbursa
approved these changes
Jan 26, 2024
aplybeah
approved these changes
Jan 26, 2024
This was referenced Jan 26, 2024
coilysiren
added a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rolls up to #1051
Time to review: 1 mins
Context for reviewers
This is it! I've decided to go "all in" on deploying dev to the new non-default VPC. Things will be kind of messy until I get everything ironed out.
I'm doing this now because #1097 is causing deploy conflicts between the default and non-default VPCs. And I figured, hey, now seems like a good time to just pull the plug. Lets roll forward into the future.
Note that, as a mention here,
api-devis currently broken. This PR will neither break nor fix it, as the primary blocker there is more-so the database role manager work. This PR just makes the situation a bit more confusing 😆 Apologies! Everything will be back into a good state soon ™️