[Issue 1051] Fix CIDR overlap #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbursa
approved these changes
Jan 25, 2024
| public_subnets = ["10.0.10.0/24", "10.0.11.0/24", "10.0.12.0/24"] | ||
| private_subnets = ["10.0.0.0/24", "10.0.1.0/24", "10.0.2.0/24"] | ||
| database_subnets = ["10.0.5.0/24", "10.0.6.0/24", "10.0.7.0/24"] | ||
| public_subnets = ["10.${var.second_octet}.10.0/24", "10.${var.second_octet}.11.0/24", "10.${var.second_octet}.12.0/24"] |
There was a problem hiding this comment.
Using the cidrsubnet function might be another option here if you prefer, instead of string interpolation. https://developer.hashicorp.com/terraform/language/functions/cidrsubnet
There was a problem hiding this comment.
@jamesbursa I looked into that! But unfortunately I didn't really parse the math TBH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rolls up to #1051
Time to review: 5 mins
Changes proposed
xin10.x.0.0) in the VPC cidr to be a variable.devs cidr is staying the same,stagingandprodare changing.Context for reviewers