Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 1086] Enable HTTP endpoint to RDS databases #1096

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

jamesbursa
Copy link
Collaborator

@jamesbursa jamesbursa commented Jan 25, 2024

Summary

Part of #1086

Time to review: 5 mins

Changes proposed

  • Add a database_enable_http_endpoint variable to the app config.
  • If the variable is set, enable the HTTP endpoint for the RDS database.
  • Set the new variable to true for all non-prod environments.

Context for reviewers

To enable work on #1086, we need to view the existing roles in the database. This enables the HTTP endpoint, which in turn enables the Query Editor on the AWS Console.

Additional information

Partial terraform plan from make infra-update-app-database APP_NAME=api ENVIRONMENT=dev:

  # module.database.aws_rds_cluster.db will be updated in-place
  ~ resource "aws_rds_cluster" "db" {
      ~ enable_http_endpoint                = false -> true
        id                                  = "api-dev"
        tags                                = {}
        # (37 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

@jamesbursa jamesbursa marked this pull request as ready for review January 25, 2024 21:37
Copy link
Collaborator

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jamesbursa jamesbursa merged commit 3ae1aa6 into main Jan 25, 2024
7 checks passed
@jamesbursa jamesbursa deleted the jamesbursa/1086-enable-http-api branch January 25, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants