[Issue 966] Configure access log S3 buckets to allow SSL requests only #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #966
Time to review: 5 mins
Changes proposed
*access-logs*buckets to allow SSL requests only.Context for reviewers
This policy is required by Security Hub control S3.5. See https://repost.aws/knowledge-center/s3-bucket-policy-for-config-rule
Additional information
Tested by deploying to dev using
make infra-update-app-service APP_NAME=api ENVIRONMENT=dev.Before deploy:
After deploy:
Confirmed that the control switched from FAILED to PASSED on Security Hub:
