[Issue 1257]: set min node version to match docker #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylew1
requested review from
andycochran,
acouch and
SammySteiner
as code owners
rylew1
commented
Feb 15, 2024
| @@ -2,6 +2,9 @@ | |||
| "name": "frontend", | |||
| "version": "0.1.0", | |||
| "private": true, | |||
| "engines": { | |||
| "node": ">=20.0.0" | |||
| }, | |||
There was a problem hiding this comment.
If you were working locally with 20.8.0 we could pin that? But it probably doesn't matter given it's just a minor version difference
There was a problem hiding this comment.
we're using node:20-bullseye-slim in the dockerfile, so this puts us in the same ballpark.
SammySteiner
approved these changes
Feb 15, 2024
rylew1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1257
Time to review: 1 min
Changes proposed