[Issues 1259] add frontend make build target #1260
Conversation
rylew1
requested review from
andycochran,
acouch and
SammySteiner
as code owners
| artillery run -e production artillery-load-test.yml |
There was a problem hiding this comment.
Not sure what this was about
| @@ -40,6 +40,9 @@ release-build: | |||
| ################################################## | |||
| # Local development | |||
| ################################################## | |||
| build: # Build the Next.js local dev server in Docker | |||
| docker-compose build --no-cache nextjs | |||
|
|
|||
There was a problem hiding this comment.
There might be a better option for updating local packages in docker - but this was the quick solution
github-actions
bot
added
the
documentation
There was a problem hiding this comment.
Approving, but please remove the dash from docker-compose before merging as that has been deprecated
frontend/Makefile
Outdated
| @@ -40,6 +40,9 @@ release-build: | |||
| ################################################## | |||
| # Local development | |||
| ################################################## | |||
| build: # Build the Next.js local dev server in Docker | |||
| docker-compose build --no-cache nextjs | |||
There was a problem hiding this comment.
| docker-compose build --no-cache nextjs | |
| docker compose build --no-cache nextjs storybook |
docker compose doesn't get a dash anymore, I also type it accidentally all the time.
let's add storybook here too, unless you want to have separate build-dev and build-storybook make commands.
can you also update our renovate review instructions with this make command here
There was a problem hiding this comment.
I propose splitting splitting up the app and storybook to make it more modular
Summary
Fixes #1259
Time to review: 1 min
Changes proposed
Context for reviewers
make dev, local docker needs to rebuild to pull in new dependencies