Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 1241] Truncate and load the transfer_topportunity table #1268

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

chouinar
Copy link
Collaborator

Summary

Fixes #1241

Time to review: 3 mins

Changes proposed

Added the truncate + load commands for copying from the Oracle foreign data wrapper table

Context for reviewers

Note that there may be a way to set this up locally for unit testing purposes, but that will require a bit of work to build out, will follow up with that work once we've manually tested and confirmed this approach works without any major modifications.

Additional information

Running locally I made a temporary table duplicated from transfer_topportunity and loaded records into it. I then loaded different records into transfer table, and ran the script, it deleted and loaded the records as expected.

Some of the logs:
Screenshot 2024-02-16 at 1 13 25 PM

Copy link
Collaborator

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

@chouinar chouinar merged commit cceab07 into main Feb 16, 2024
8 checks passed
@chouinar chouinar deleted the chouinar/1241-truncate-load-opp branch February 16, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Implement the copy commands reading via the Oracle foreign data connector
2 participants