[Issue #1746] Add transformations for assistance listing table #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
requested review from
acouch,
aplybeah and
SammySteiner
as code owners
jamesbursa
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1794 - which it builds upon.
Summary
Fixes #1746
Time to review: 10 mins
Changes proposed
Adds transformation logic for the assistance listing (formerly CFDA) tables.
Context for reviewers
The transformations are pretty uneventful, the only complexity is that the legacy Oracle database doesn't have a foreign key between the
TopportunityCfdatable and theTopportunitytable and there are ~2300 orphaned cfda records that we wouldn't be able to import, so we additionally need to validate that the opportunity exists when we try to transform the data, and if not, we just mark it as "transformed" and do nothing with it.There is some basic work on relationships between the staging tables + more factories for setting up the data which will be ongoing / @jamesbursa is also looking into.