Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Concurrent Releases #2236

Merged
merged 15 commits into from
Sep 27, 2024
Merged

Handle Concurrent Releases #2236

merged 15 commits into from
Sep 27, 2024

Conversation

coilysiren
Copy link
Collaborator

@coilysiren coilysiren commented Sep 26, 2024

Summary

Fixes #1919

Time to review: 5 mins

Changes proposed

This PR makes two changes:

Context for reviewers

I used this commit to test: https://github.com/HHS/simpler-grants-gov/actions/runs/11059113106/job/30727162490

@coilysiren coilysiren self-assigned this Sep 26, 2024
@coilysiren coilysiren marked this pull request as ready for review September 26, 2024 21:05
@coilysiren coilysiren requested a review from acouch September 26, 2024 21:06
acouch
acouch previously approved these changes Sep 27, 2024
Copy link
Collaborator

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally now.

mdragon
mdragon previously approved these changes Sep 27, 2024
@coilysiren coilysiren dismissed stale reviews from mdragon and acouch via be3c56d September 27, 2024 16:10
@coilysiren
Copy link
Collaborator Author

Resolved a small merge conflict in the last commit

Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@coilysiren coilysiren merged commit bea90ec into main Sep 27, 2024
6 of 7 checks passed
@coilysiren coilysiren deleted the kai/concurrent-releases branch September 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Deploying to (dev, or staging) fails because trying to release the same image tag twice
3 participants