-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue 97] Front-end Framework ADR #236
[issue 97] Front-end Framework ADR #236
Conversation
- Supports static site generation, server side rendering, and client side rendering | ||
- Easy to learn and use with good documentation | ||
- **Cons** | ||
- Very opinionated framework, especially with routing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely worth pointing out. But, of course, an opinionated framework is not necessarily a con, especially as a project scales. So many choices you don't have to make. This could just as easily be phrase differently in the "Pros" list. (Just my two cents, having worked in EmberJS quite extensively.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out, and in general I agree that having an opinionated framework can help reduce complexity/decisions.
I updated to add a bit more context. There is discussion of the opinionatedness in it's routing adding a lot of unnecessary code for non standard routes. Not sure if this is even something we'll experience in the project, but it's the one con I see mentioned about Next.js in a lot of places so I thought it worth mentioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm… I'm not too familiar with the specifics of Next's issues with unusual routing. But, IIRC, the latest release changed quite a lot about how routing works. Might some of those issues have been resolved, or some of the chatter/complaints be old?
Summary
Fixes #97
Time to review: 10
Changes proposed