Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 97] Front-end Framework ADR #236

Merged
merged 12 commits into from
Jul 14, 2023

Conversation

SammySteiner
Copy link
Contributor

@SammySteiner SammySteiner commented Jul 13, 2023

Summary

Fixes #97

Time to review: 10

Changes proposed

Added ADR for front-end framework

@SammySteiner SammySteiner added the docs: adr Architecture decision record ticket label Jul 13, 2023
@SammySteiner SammySteiner marked this pull request as ready for review July 13, 2023 15:38
- Supports static site generation, server side rendering, and client side rendering
- Easy to learn and use with good documentation
- **Cons**
- Very opinionated framework, especially with routing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely worth pointing out. But, of course, an opinionated framework is not necessarily a con, especially as a project scales. So many choices you don't have to make. This could just as easily be phrase differently in the "Pros" list. (Just my two cents, having worked in EmberJS quite extensively.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out, and in general I agree that having an opinionated framework can help reduce complexity/decisions.
I updated to add a bit more context. There is discussion of the opinionatedness in it's routing adding a lot of unnecessary code for non standard routes. Not sure if this is even something we'll experience in the project, but it's the one con I see mentioned about Next.js in a lot of places so I thought it worth mentioning.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm… I'm not too familiar with the specifics of Next's issues with unusual routing. But, IIRC, the latest release changed quite a lot about how routing works. Might some of those issues have been resolved, or some of the chatter/complaints be old?

@SammySteiner SammySteiner merged commit a561b36 into main Jul 14, 2023
@SammySteiner SammySteiner deleted the sammysteiner/issue-97-front-end-framework branch July 14, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs: adr Architecture decision record ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADR]: Frontend Framework
3 participants