[Issue #3103] Pass client assertion jwt to token endpoint #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3103
Time to review: 10 mins
Changes proposed
Changed the way we call the OAuth token endpoint to use private_key_jwt
Added docs for how to setup Login.gov certs
Context for reviewers
For the first pass, I setup the call to the token endpoint to use client_id, but actual Login.gov uses private_key_jwt for this instead (which includes the client ID). Luckily it seems our local mock is fine with that and can take in this as well. It doesn't do any validation on the key itself, so any private key is fine.
Effectively, this form of "auth" is just passing the client ID + a hash that could have only been created by our private key, and login.gov is configured to have our public key.
Additional information
For testing this, I actually connected it to our dev login.gov app which I setup alongside it. It works! Also verified exactly what we need to set for many of the env vars to get everything happy.
You get directed first to:
And then back to our API and then the final endpoint with a token that works locally.