[Unticketed] Update package.json to remove dep i18n #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-s-nava
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
everything seems to run fine
✅ ✅ ✅ ✅ ✅
I do wonder what plans, if any, we have for translations on storybook though. I assume the idea was that the storybook-react-i18next package was going to be providing something there, and I don't see anything else lined up to take its place...
1 task
|
@doug-s-nava good question. Looks like this might be the way to go with that: https://github.com/stevensacks/storybook-next-intl I created a ticket: #3236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes NA
Time to review: 5 mins
Changes proposed
Remove deprecated i18n packages.