[Issue #3204] Remove opportunities connected to test agencies from search results #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3204
Time to review: 5 mins
Changes proposed
If an opportunity is connected to a test agency, do not load it into the search index
Fixed a bug with how incremental updates/deletes worked that was deleting everything if it wasn't in an update
Context for reviewers
Certain agencies are marked as test agencies, and will be excluded from appearing in the left-hand navigation already. However, that doesn't stop you from finding them in search results by other means. Even though the number of test records appearing in search is small (5 at the time of writing), we'll be cautious and just filter them all out, which lets us potentially do more in the future as well.
We also handle deleting anything that already exists in the incremental job - that likely won't matter in most cases, but if an agency is ever marked as a test that wasn't previously, we'll handle that.
Additional information
In prod, there are only 5 opportunities this will actually filter out right now, some subagencies aren't included in the list yet, but we'll deal with that separately:
https://simpler.grants.gov/search?agency=GDIT,IVV,IVPDF,0001,FGLT,NGMS,NGMS-Sub1,SECSCAN&status=forecasted,posted,archived,closed