[Issue #680] Adds the CDN back #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
commented
Dec 16, 2024
Comment on lines
-12
to
-16
| variable "domain" { | ||
| type = string | ||
| description = "DNS domain of the website managed by HHS" | ||
| default = null | ||
| } |
There was a problem hiding this comment.
This isn't used and has never been used
coilysiren
commented
Dec 16, 2024
Comment on lines
+95
to
+100
| viewer_certificate { | ||
| acm_certificate_arn = var.cert_arn == null ? null : var.cert_arn | ||
| cloudfront_default_certificate = var.cert_arn == null ? true : false | ||
| minimum_protocol_version = local.minimum_protocol_version | ||
| ssl_support_method = "sni-only" | ||
| } |
There was a problem hiding this comment.
I didn't have this bit fully details before, and it broke a prod deploy
There was a problem hiding this comment.
Everything else is just uncommenting existing work
coilysiren
commented
Dec 16, 2024
Comment on lines
+5
to
+6
| ssl_protocols = ["TLSv1.2"] | ||
| minimum_protocol_version = "TLSv1.2_2021" |
There was a problem hiding this comment.
These were chosen randomly on my part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #680
Time to review: 5 mins
Changes proposed
Testing
I deployed this to both dev (without the cert) and staging (with the cert) to test