Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 321] Standardize Github Action workflow naming conventions #324

Merged
merged 8 commits into from
Jul 24, 2023

Conversation

daphnegold
Copy link
Contributor

@daphnegold daphnegold commented Jul 24, 2023

Summary

Fixes #321

Time to review: 3 mins

Changes proposed

Update naming of GA workflows that will be used in PR checks to be clearer.

  • Smash front-end checks for linting, testing, format checking and type checking together. They were separate and doing separate npm ci installs for each. Extra time + making PR checks look quite cluttered. If you want to see a specific, you can click on "details" and then expand the section that you're interested in, same as when they were separated.
  • Update path naming for API workflow because it was wrong and not getting run.
  • Leave FE & API in naming convention for sub-categories of workflows. The reasoning is that when setting up branch protection rules, it makes it easier to find the check you're looking for since you search by sub-category. It does look a bit redundant on PRs, but doesn't bother me, personally. Thoughts? The Github UI here is less than ideal.
Screenshot 2023-07-24 at 12 24 48 PM

@daphnegold daphnegold added the topic: infra Infrastructure related tickets label Jul 24, 2023
@daphnegold daphnegold requested a review from widal001 July 24, 2023 17:54
Copy link
Contributor

@SammySteiner SammySteiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for streamlining this 🚀

@daphnegold daphnegold merged commit 30d76f0 into main Jul 24, 2023
@daphnegold daphnegold deleted the daphnegold/issue-321-ga-naming branch July 24, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infra Infrastructure related tickets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Standardize Github Action workflow naming conventions
2 participants