[Issue #3183] Make search facets for agencies return more than 25 agencies #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-s-nava
pushed a commit
that referenced
this pull request
Dec 30, 2024
…ncies (#3273) ## Summary Fixes #3183 ### Time to review: __3 mins__ ## Changes proposed Modify the search facet count logic to allow up to 1000 unique agencies in response ## Context for reviewers By default we configured the size to be 25 arbitrarily. There are about 700 agencies with opportunities in prod, so configured a number a bit above that for now. We might want to consider allowing the user of the API to specify the facets they want in the future. ## Additional information I loaded a lot of opportunities into the search index, and the response for facet counts now has all of the agencies we have configured locally with is about 80.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3183
Time to review: 3 mins
Changes proposed
Modify the search facet count logic to allow up to 1000 unique agencies in response
Context for reviewers
By default we configured the size to be 25 arbitrarily. There are about 700 agencies with opportunities in prod, so configured a number a bit above that for now.
We might want to consider allowing the user of the API to specify the facets they want in the future.
Additional information
I loaded a lot of opportunities into the search index, and the response for facet counts now has all of the agencies we have configured locally with is about 80.