Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainer #3351

Closed
wants to merge 1 commit into from
Closed

Devcontainer #3351

wants to merge 1 commit into from

Conversation

timscharfenort8
Copy link

Summary

Fixes #{ISSUE}

Time to review: x mins

Changes proposed

What was added, updated, or removed in this PR.

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

@btabaska
Copy link
Collaborator

btabaska commented Jan 6, 2025

Thank you for submitting open source code to our project. We hold our PRs to a standard of following our template when merging to describe the changes that you are looking to make and why. I don't see any information about this change or why we would merge it into our main branch. Please follow up with the Changes Proposed, Context for reviewers, and any additional information that you think we should have to fully consider the implications of merging this code.

@btabaska btabaska self-requested a review January 6, 2025 20:56
Copy link
Author

@timscharfenort8 timscharfenort8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

Copy link
Collaborator

@btabaska btabaska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been a few weeks and we have not gotten a response to the reasoning for this change. Recommend closing this PR until the contributor is ready to resubmit with the correct PR information provided.

@btabaska btabaska closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants