Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 3266] mod factories opp attach staging #3370

Merged
merged 23 commits into from
Jan 7, 2025

Conversation

babebe
Copy link
Collaborator

@babebe babebe commented Jan 2, 2025

Summary

Fixes #{3266}

Time to review: 10 mins

Changes proposed

Added class method to staging and foreign Opportunity Factory
Added test

@babebe babebe changed the title 3266/mod factories opp attach staging [Issue 3266] mod factories opp attach staging Jan 2, 2025
Copy link
Collaborator

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was some confusion on this ticket - you are making new factories - do not modify the existing TopportunityFactory in any way.

api/tests/src/db/models/factories.py Outdated Show resolved Hide resolved
api/tests/src/db/models/factories.py Outdated Show resolved Hide resolved
api/tests/src/db/models/factories.py Outdated Show resolved Hide resolved
@babebe babebe requested a review from chouinar January 6, 2025 22:08
@babebe babebe merged commit 89581c1 into main Jan 7, 2025
2 checks passed
@babebe babebe deleted the 3266/mod_factories_opp_attach_staging branch January 7, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants