Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #3312] delete cd-*-infra workflows #3389

Merged
merged 3 commits into from
Jan 6, 2025
Merged

[Issue #3312] delete cd-*-infra workflows #3389

merged 3 commits into from
Jan 6, 2025

Conversation

coilysiren
Copy link
Collaborator

Summary

Fixes #3312

Time to review: 2 mins

Context

I realized recently that race conditions from the regular deploys and the infra deploys would reliably cause problems. So I wondered, why would platform do this? How have they solve it? Well... platform doesn't have infra deploys that are separate from the application deploys. Which sounds like a reasonable solution this problem I guess. So that's the solution I'm going with.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
mdragon
mdragon previously approved these changes Jan 3, 2025
Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. We had talked about whether there were any corner cases where we wouldn't want to deploy the application for an infra change, but those are probably not a big deal, compared to regular deploys getting mucked up more often.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@coilysiren coilysiren requested a review from mdragon January 6, 2025 17:33
Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@coilysiren coilysiren merged commit 0216532 into main Jan 6, 2025
6 checks passed
@coilysiren coilysiren deleted the kai/no-cd-infra branch January 6, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants